Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address developer experience around Job#job_type #84

Closed
robacarp opened this issue Feb 14, 2022 · 0 comments · Fixed by #86
Closed

Address developer experience around Job#job_type #84

robacarp opened this issue Feb 14, 2022 · 0 comments · Fixed by #86

Comments

@robacarp
Copy link
Collaborator

robacarp commented Feb 14, 2022

The current implementation for how to specify which queues a job should land in is opaque:

class GeneratorJob < QueuedJob
   def self.job_type
     "generator"
  end

  # ...etc
end

Should Job#job_type be renamed? Should a macro be provided to make that feature less verbose? At a minimum documentation should be added to the method so it's clear what it's supposed to do.

see #80 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant