-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiring jobs #41
Labels
Milestone
Comments
@greenbigfrog thanks for looking and jumping in! This idea fits into a broad category of a pre and post-exec hooks I've been eyeing adding. 🌵 Eventually, I'd like to move the throttling code into a pre-exec hook as well, which can be included into a Job class as needed. |
Have you started work on the hook stuff yet somewhere?
…On Wed, Feb 12, 2020, 21:59 robacarp ***@***.***> wrote:
@greenbigfrog <https://github.com/greenbigfrog> thanks for looking and
jumping in!
This idea fits into a broad category of a pre and post-exec hooks I've
been eyeing adding. 🌵 Eventually, I'd like to move the throttling code
<https://github.com/robacarp/mosquito/blob/master/src/mosquito/job.cr#L96-L111>
into a pre-exec hook as well, which can be included into a Job class as
needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPL27W4JOPCXYBAABV3SZ3RCRPKBANCNFSM4KTZRPVQ>
.
|
Sorry, no |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for all the work that's gone into this.
One feature I'd like to see added would be expiring jobs. If a job can't/isn't processed within/until X, it won't run.
Example: if I add a job to the queue, I only want it to run within the next 30 seconds. If the worker is not running or doesn't process the job within 30 seconds, it shouldn't work the job.
I'll look into implementing this myself sometime the next week.
The text was updated successfully, but these errors were encountered: