Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a job schema changes, added optional parameters shouldn't cause the job to fail. #149

Open
robacarp opened this issue Oct 27, 2024 · 0 comments
Assignees

Comments

@robacarp
Copy link
Collaborator

Today I added an optional parameter to a job:

+  param ignore_last_indexed_at : Bool = false 

Several thousand jobs were in queue at the time of deploy and started rapidly failing because they weren't stored with the parameter. It would have been an easier transition to allow those jobs to run as is, and just take the default value of the parameter.

If it's not that way already, job parameters which are no longer present in the definition should also not prevent the job from running. Perhaps this means there should be an "unknown parameters hash" or something similar, following the pattern of StdLib's JSONSerializable.

Crystal version: 0.28.0
Mosquito Shard version: 0.4.0

@robacarp robacarp self-assigned this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant