Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two more screen functions need to be queue funtions so that operations properly synced #1808

Open
skibu opened this issue Jan 27, 2025 · 2 comments

Comments

@skibu
Copy link
Contributor

skibu commented Jan 27, 2025

This issue is very similar to PR #1795 . I found two more screen drawing functions that need to be queue functions so that all the drawing functions are executed in the proper order. Otherwise drawing can end up with completely incorrect results.

Tagging @tlubke since they were the one who properly fixed the similar issues in PR #1795 .

The functions that need to be made into queue functions are:

  • image:_context_focus()
  • image:_context_defocus()

For more info on the problem and how I added a hack to normsLib to get around it, see: https://github.com/skibu/nornsLib/blob/eecaba928f5972363c75087cbb407d09efb7092c/screenExt.lua#L142

@tlubke
Copy link
Collaborator

tlubke commented Jan 29, 2025

I actually had some work done in this area already if you want to checkout
f2f8eb6 on tlubke/#1808. I think every screen function called by image:_context_focus() and image:_context_defocus() now has a proper event in that branch.

It's not quite PR-ready though. After looking over it just once, I found that SCREEN_RESULTS_SURFACE_GET_EXTENTS is not handled in the switch statement inside screen_results_free().

@Dewb
Copy link
Collaborator

Dewb commented Jan 29, 2025

related: #1747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants