Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend validation email route #8

Open
ethanfine opened this issue Mar 9, 2016 · 4 comments
Open

Resend validation email route #8

ethanfine opened this issue Mar 9, 2016 · 4 comments

Comments

@ethanfine
Copy link
Contributor

We need a route which resends the validation email.

@akaplo
Copy link

akaplo commented Mar 26, 2016

This would actually be an ms-email issue.

That said, I don't see a use for a resend route because the existing validate route doesn't care whether you've already sent the email. As long as you continue to pass it the proper params, it'll send as many as you like!

So, the front-end could just have logic where a link to "resend activation email" simply calls /validate again.

@ethanfine
Copy link
Contributor Author

That's false.
ms-email is not a public microservice. Only other microservices use it. This is because it sends arbitrary emails.
In addition it (obviously) has no direct access to the database. THe validate route is simply an email form filled out with info sent from the users microservice.
A resend route would call the ms-email validate route.

@akaplo
Copy link

akaplo commented Mar 26, 2016

You're right. I'll take care of that.

@akaplo
Copy link

akaplo commented Apr 20, 2016

Or will I? Not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants