Icons not loading in Windows and MacOS

[abhi211199]

Describe the bug
The app's icon(currently, the moja global icon) successfully loads in Ubuntu, but fails to load in Windows and MacOS based systems.
Making proper entries in package.json and main.js should fix it!

[gmajan]

Thx for this issue.

[waridrox]

Describe the bug
The app's icon(currently, the moja global icon) successfully loads in Ubuntu, but fails to load in Windows and MacOS based systems.
Making proper entries in package.json and main.js should fix it!

I tried adding the icon file for specific operating systems, .icns, .png and .ico respectively, and the app icon does change but after rebuilding the app, the app size reduces to 192.8 MB which was 204.5 MB otherwise. The functionality is also hindered where the JSON interface is not loading. I think there are some dependencies that are broken.

Tested on MacOS 11.0.1

Same problem arises with the .exe file on Windows 10

[aornugent]

@waridrox - can you please describe which dependencies might not be working correctly?

[waridrox]

@waridrox - can you please describe which dependencies might not be working correctly?

After researching a bit more about the problem, I found that the problem is not with the dependencies but with the Electron itself which has been linked here.

The app is not able to build properly even on the different electron app versions and methods as suggested in the above issue.
Adding the icon path, does change the icon but removes other images from the app. There are no problems though when testing on local development environment with npm start.

providing the icon path for the electron app

app running perfectly on the local server

I would like @abhi211199 to provide his opinions on the same and see if the issue can be solved.

[Axuby]

Nice @waridrox

[shreya024]

Hi, I am Shreya, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you