Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyCodeStyle does not remember setting (off) #8

Open
johnsturgeon opened this issue Nov 14, 2020 · 10 comments
Open

PyCodeStyle does not remember setting (off) #8

johnsturgeon opened this issue Nov 14, 2020 · 10 comments

Comments

@johnsturgeon
Copy link

Every time I restart Nova, PyCodeStyle shows me errors. To fix it, I have to go into the Python-Nova settings and toggle it 'on' and 'off' again.

@Gugu7264
Copy link

Gugu7264 commented Dec 2, 2020

I agree, it's very disturbing. You can also change a setting of PyCodeStyle so it does apply.

@mmshivesh
Copy link
Owner

Hmm, i'll take a look at this, i've been really busy these past few weeks and i will come back to fixing bugs soon

@samdoran
Copy link

I run into this issue daily as well.

@samdoran
Copy link

samdoran commented Jan 25, 2021

It seems like this may be related to the fact that settings are not getting loaded on initial launch.

client.sendNotification("workspace/didChangeConfiguration", getSettings());

Changing any setting after the extension has loaded causes the correct settings to take affect. Odd because this is the same method call.

this.languageClient.sendNotification("workspace/didChangeConfiguration", getSettings())

@mmshivesh
Copy link
Owner

mmshivesh commented Jul 9, 2021

@samdoran You are correct. The whole preferences loading thing seems to be very wonky. I'm primarily a python dev and I've barely used JS before this project, but if anyone has more insights/better ways to parse/handle preferences, I'm all ears.

@johnsturgeon
Copy link
Author

Sad to say. Because I love Nova. I gave in and moved to PyCharm for Python. Still use nova but for python it's not ready for prime time

@mmshivesh
Copy link
Owner

IMO, the bigger problem I'm grappling with is the lack of great open source Python Language servers. The current LS that this extension uses is Palantir's Python LS but it's slow. Microsoft per usual hasn't open sourced their excellent PyLance server that's bundled with VSCode. Their older Python-Language-Server hasn't received updates since last year.

I might be able to get everything working if I write substantially more code, doing stuff akin to what Nova's typescript extension does.

@samdoran
Copy link

I'm primarily a python dev and I've barely used JS before this project

Same here. I know enough JS to be dangerous, but not very useful. 😁

IMO, the bigger problem I'm grappling with is the lack of great open source Python Language servers.

I see what you mean. It's unfortunate that PyLance is not open source. There is a fork of python language server that seems actively maintained. No idea if it's any faster than Palanitr's.

@mmshivesh
Copy link
Owner

mmshivesh commented Jul 14, 2021

There is a fork of python language server that seems actively maintained. No idea if it's any faster than Palantir's.

Yes, I did take a look at that and am using it rn. But it's essentially the same, (afaik, it's a drop in replacement for Palantir's version). It's nothing groundbreaking like Microsoft's Pylance tbh.

@guillaumealgis
Copy link
Contributor

Probably fixed in #19

Maybe also related to #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants