Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noting a macOS 15 Beta 3 crash #114

Closed
ZachNagengast opened this issue Jul 15, 2024 · 2 comments
Closed

Noting a macOS 15 Beta 3 crash #114

ZachNagengast opened this issue Jul 15, 2024 · 2 comments

Comments

@ZachNagengast
Copy link

We're working through MLX support over in WhisperKit and noticed a crash that happens on macOS 15 but not 14. It occurs on this particular test, oddly many of the other tests still pass.

How to replicate:

git clone https://github.com/argmaxinc/WhisperKit.git
cd WhisperKit
git checkout mlx-support
make setup
make download-mlx-models
xcodebuild test -only-testing WhisperKitMLXTests/MLXUnitTests -scheme whisperkit-Package -destination "platform=macOS"

Or to run them in xcode,

xed .

And open up the tests, then run the MLXUnitTests suite, particularly testEncoderOutput

image

This throws the following assert:

template <class _Tp, class _Allocator>
_LIBCPP_CONSTEXPR_SINCE_CXX20 inline _LIBCPP_HIDE_FROM_ABI typename vector<_Tp, _Allocator>::const_reference
vector<_Tp, _Allocator>::operator[](size_type __n) const _NOEXCEPT {
  _LIBCPP_ASSERT_VALID_ELEMENT_ACCESS(__n < size(), "vector[] index out of bounds");
  return this->__begin_[__n];
}

Where __n is 3 and I cant tell what size() is but I would assume less than or equal to 3.

@awni
Copy link
Member

awni commented Jul 15, 2024

This is probably a dup of #104, which is fixed in MLX core and should be picked up in swift in the next release (week or so).

@ZachNagengast
Copy link
Author

Ah great, will use -configuration Release in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants