Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin initialization error unclear #880

Open
patrickjcasey opened this issue Feb 4, 2025 · 0 comments · May be fixed by #896
Open

plugin initialization error unclear #880

patrickjcasey opened this issue Feb 4, 2025 · 0 comments · May be fixed by #896
Assignees
@cstepanian

Comments

@patrickjcasey
Copy link
Contributor

Image

This output does not make it clear which plugin had an error being initialized. Also as a small nitpick, there should be a space or some delimiter between string and configuration
@cstepanian cstepanian self-assigned this Feb 4, 2025
cstepanian added a commit that referenced this issue Feb 8, 2025
@cstepanian
feat: Improve error message context from plugins
4d9d0a1 
Resolves #880

- Print plugin errors with full context, like which file could not be opened.
- Clarify wording of some error messages.
- Add miette dependency to print helpful KDL parsing errors.

Signed-off-by: Cal Stepanian <[email protected]>
@cstepanian cstepanian mentioned this issue Feb 8, 2025
Open
cstepanian added a commit that referenced this issue Feb 8, 2025
@cstepanian
feat: Improve error message context from plugins
0f03bba 
Relates to #880

- Print plugin errors with full context, like which file could not be opened.
- Clarify wording of some error messages.
- Add miette dependency to print helpful KDL parsing errors.

Signed-off-by: Cal Stepanian <[email protected]>
cstepanian added a commit that referenced this issue Feb 9, 2025
@cstepanian
feat: Track plugin name and version when reporting startup errors
9dbad03 
Resolves #880

Add plugin version to the `Plugin` struct so that it's available when
starting plugins.

Also add logging when Hipcheck retrieves and starts plugins.

Signed-off-by: Cal Stepanian <[email protected]>
cstepanian added a commit that referenced this issue Feb 10, 2025
@cstepanian
feat: Track plugin name and version when reporting startup errors
6498c10 
Resolves #880

Add plugin version to the `Plugin` struct so that it's available when
starting plugins.

Also add logging when Hipcheck retrieves and starts plugins.

Signed-off-by: Cal Stepanian <[email protected]>
@cstepanian cstepanian linked a pull request Feb 10, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cstepanian cstepanian

Labels
None yet
Projects
Hipcheck Dev Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Track plugin name and version when reporting startup errors mitre/hipcheck
2 participants
@patrickjcasey @cstepanian