You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any particular reason that the functions setXForwardedForHeader and getContentLength are not protected instead of private? This allows others to extend this class without the need to modify it.
The text was updated successfully, but these errors were encountered:
It's easy to overlook this. I definitely think setXForwardedForHeader ought to be protected. I'm not sure why getContentLength would need to be overridden but, hey, why not.
Thanks for the quick response. setXForwardedForHeader was definitely the one I was thinking of, but just added the only other private function in that class.
Any particular reason that the functions setXForwardedForHeader and getContentLength are not protected instead of private? This allows others to extend this class without the need to modify it.
The text was updated successfully, but these errors were encountered: