Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hooks don't include scss_lint with same parameters #1985

Open
pt2302 opened this issue Sep 22, 2023 · 0 comments
Open

Pre-commit hooks don't include scss_lint with same parameters #1985

pt2302 opened this issue Sep 22, 2023 · 0 comments
Labels
bug Something isn't working product:ocw

Comments

@pt2302
Copy link
Contributor

pt2302 commented Sep 22, 2023

Expected Behavior

The pre-commit hooks should catch linting errors with scss, by also running scss_lint with the same parameters as when running npm run scss_lint.

Current Behavior

Pre-commit is not catching all linting errors, but tests will fail when pushed to GitHub.

Steps to Reproduce

Introduce the error Expected empty line before rule rule-empty-line-before into a modified .scss file. Pre-commit will still pass.

@pt2302 pt2302 added bug Something isn't working product:ocw labels Sep 22, 2023
@pt2302 pt2302 changed the title Pre-commit hooks don't include scss_lint Pre-commit hooks don't include scss_lint with same parameters Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product:ocw
Projects
None yet
Development

No branches or pull requests

1 participant