New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback dialog is hard to dismiss #1094

Open

ChristopherChudzicki opened this issue Feb 23, 2023 · 0 comments

Contributor

ChristopherChudzicki commented Feb 23, 2023 •

edited

Loading

Steps to Reproduce

On any page at ocw (e.g., https://ocw.mit.edu or https://ocw.mit.edu/courses/3-091-introduction-to-solid-state-chemistry-fall-2018/ or the search page):

Click feedback button (it appears on right edge when mouse is near there)
A feedback dialog opens
Click outside the dialog

Expected Behavior

The dialog should close whenever a click outside the dialog occurs
The dialog should close if "Escape" is pressed when it is open
The X button should always be visible.

Actual Behavior

The X button is only visible when hovering the dialog... E.g., See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role#required_javascript_featuresw

it should trap focus
something inside it should be focused automatically when it is opened.

Other issues

There are some additional issues related to this dialog, e.g. something inside it should be auto-focused, and it should trap keyboard focus.

Screenshot or Screencast

hard_to_dismiss.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment