-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for editing exifs #13
Comments
Hi @i5-650 Thank you for your feedback! I will definitely consider adding editing features in future versions. However, it may be done step by step based on priority. For example, we might start with some commonly used editing features, such as:
Do you have any suggestions? Or are there other editing features you’d like to see prioritized? Please feel free to share your thoughts. Thank you! |
Great! You've already mentioned the most important points (in my opinion), but I’d like to expand on this. My goal is to edit all EXIF data in a file, particularly for images. If I may suggest a few thing:
|
I think the serialization function should be considered already available, just Deserialization may be a bit problematic, mainly because there should be no way |
Yes, serialization is already implemented (and it's great!), but I think we might be able to work around deserialization in some way. (I'm not an expert on EXIFs, so please correct me if I'm wrong.) Based on the tag name, we could define an Enum that might look something like this: #[derive(Debug, Serialize, Deserialize)]
enum ExifTag {
SonyRawImageSize(i16),
BlackLevel(i16),
ExposureTime(f32),
IsoSpeed(i32),
// Add more EXIF tags and their types here
} Therefore, we could serialize from a JSON file! However, that would imply having a huge Enum... Let me know what you think about that |
In fact, |
Hey,
Do you plan on adding support for editing exits ?
That would make me switch from rexiv2 to your lib.
The text was updated successfully, but these errors were encountered: