From c0f5112b8d1832c2e5b5545d5253d1db41bdf5f7 Mon Sep 17 00:00:00 2001 From: Mike Brady <4265913+mikebrady@users.noreply.github.com> Date: Wed, 24 Apr 2024 10:31:10 +0100 Subject: [PATCH] Remove some almost-never-used and therefore untested code, and remove a potentially misleading comment from the ALSA backend. --- audio_alsa.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/audio_alsa.c b/audio_alsa.c index 787808049..bcd2d6a4f 100644 --- a/audio_alsa.c +++ b/audio_alsa.c @@ -938,9 +938,9 @@ static int prepare_mixer() { } else { // use the linear scale and do the db conversion ourselves warn("The hardware mixer specified -- \"%s\" -- does not have " - "a dB volume scale.", + "a dB volume scale, and so can not be used by Shairport Sync.", alsa_mix_ctrl); - + /* if ((response = snd_ctl_open(&ctl, alsa_mix_dev, 0)) < 0) { warn("Cannot open control \"%s\"", alsa_mix_dev); } @@ -961,9 +961,10 @@ static int prepare_mixer() { // we know it can do dB stuff audio_alsa.parameters = ¶meters; // likewise the parameters stuff } else { - debug(1, "Cannot get the dB range from the volume control \"%s\"", alsa_mix_ctrl); + debug(1, "Cannot get a dB range from the volume control \"%s\"", alsa_mix_ctrl); } } + */ } } if (((config.alsa_use_hardware_mute == 1) &&