Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show all edges removed #7

Open
honghaoli42 opened this issue Apr 2, 2020 · 5 comments
Open

Add option to show all edges removed #7

honghaoli42 opened this issue Apr 2, 2020 · 5 comments
Labels
enhancement New feature or request minor

Comments

@honghaoli42
Copy link
Collaborator

honghaoli42 commented Apr 2, 2020

Original report by Marcel Ribeiro-Dantas (Bitbucket: mribeirodantas_, ).


We recently changed MIIC so that by default the final result variable has information on all edges. For the removed edges, it keeps both edges removed by marginal independence and edges removed by conditioning on a sep set.

Now, we should bring it back to the way it was before (by default, do not keep info about edges removed by marginal independence) but add a parameter so that, if set, these edges are kept in the final result variable.

@honghaoli42 honghaoli42 added major enhancement New feature or request labels Jul 24, 2020
@honghaoli42
Copy link
Collaborator Author

@mribeirodantas What's the current status of this? Is the option implemented?

@mribeirodantas
Copy link
Member

At first, what I had in mind was to leave this to the webserver. The user could easily show only non-removed edges through the filter widget (type). However, thinking about it now, R-package users could benefit from a parameter that would keep only the retained edges in the final result variable.

We'd have a parameter that, if set, would keep removed edges information in the final variable or, otherwise, they're removed (default behavior). I can implement that. What do you think?

@honghaoli42
Copy link
Collaborator Author

I suppose by "removed edges" you mean those removed with marginal independence (without conditioning)?
From what I see it's already implemented but commented out for some reason:

# List of negative edges with null conditioning set
indep_null_cond_set_edges <- as.matrix(edges[(is.na(edges$ai.vect)) &
edges$category != 1, c("x", "y")])
# Add to summarized edges list
summarized_edges <- rbind(summarized_edges, conditioned_edges)
#indep_null_cond_set_edges)

So you can simply add a parameter as a condition, though I don't quite see the interest in having those edges shown because the size of the edge list would be of the order of n_nodes^2

@mribeirodantas
Copy link
Member

I had thought of having (a) only retained edges at the end or (b) all edges (retained and removed, either by conditional independence or not). I agree that the number of edges can be very large, I even brought this up to Hervé and his reply was that people could turn off this through the parameter if they wanted so. I don't really mind, to be honest. What do you think?

@honghaoli42
Copy link
Collaborator Author

I think edges removed with conditioning should be kept (as what we have currently) because they have information on the orientation of retained edges.
You can add the parameter, and i agree that it should be turned off by default.

@honghaoli42 honghaoli42 added minor and removed major labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

2 participants