Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how we move files in gerbil codebase. #1278

Closed
teggotic opened this issue Dec 8, 2024 · 1 comment · Fixed by #1281
Closed

Improve how we move files in gerbil codebase. #1278

teggotic opened this issue Dec 8, 2024 · 1 comment · Fixed by #1281

Comments

@teggotic
Copy link

teggotic commented Dec 8, 2024

Create new move-file utility function. It would try calling rename-file, and if it fails with Invalid cross-device link error, i.e. EXDEV syscall errno, it should call a copy-file function instead.
As part of this issue, we should also update gerbil codebase to use new move-file function to prevent errors in some edgecases.

This is the result of the investigation in issue #1277.
Short summary:
While looking at gxtags implementation of the vi format, I found that rename-file call fails with "Invalid cross-device link" error on my system, because I have /tmp mounted as a different file system. Such cases specifically are not supported by rename syscall, which as far as we can tell is used intenally by the gambit's ##rename-file implementation.

@vyzo
Copy link
Collaborator

vyzo commented Dec 8, 2024

Implementation at #1281

@vyzo vyzo closed this as completed in #1281 Dec 8, 2024
@vyzo vyzo closed this as completed in add552d Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants