Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Videos on a Single Page #109

Open
TMHDesign opened this issue Feb 14, 2023 · 3 comments
Open

Multiple Videos on a Single Page #109

TMHDesign opened this issue Feb 14, 2023 · 3 comments
Labels
question Further information is requested

Comments

@TMHDesign
Copy link

TMHDesign commented Feb 14, 2023

The link elements below all open a modal, but every one opened only has the data-id for the first element. I have a page with 100 video thumbnails, and want to open each one upon a click.

<a href="javascript:void" data-type="youtube" data-id="98DXe3uKwfc" class="lightbox">ABS Braking System</a> <a href="javascript:void" data-type="youtube" data-id="bRcDvCj_JPs" class="lightbox">Partial Clutch Depression</a> <a href="javascript:void" data-type="youtube" data-id="devo3kdSPQY" class="lightbox">How Clutches Work</a> <a href="javascript:void" data-type="youtube" data-id="ewcWN-rHQ6Q" class="lightbox">Electric vs. Petrol</a> <a href="javascript:void" data-type="youtube" data-id="3SAxXUIre28" class="lightbox">How Electric Autos Work</a> <a href="javascript:void" data-type="youtube" data-id="ARd-Om2VyiE" class="lightbox">Planetary Gear Set</a> <a href="javascript:void" data-type="youtube" data-id="auQgOtveQi0" class="lightbox">Automatic vs. Manual Transmission</a> <a href="javascript:void" data-type="youtube" data-id="lFAtc-zOKZs" class="lightbox">Dual Clutch Transmission</a>

@midzer
Copy link
Owner

midzer commented Mar 24, 2023

Hi @TMHDesign

Do I understand the issue correctly, that you want to open multiple videos with a single click?

@midzer midzer added the question Further information is requested label Mar 24, 2023
@viliusle
Copy link
Collaborator

viliusle commented Mar 24, 2023

Strange bug, but if you add correct href attribute like href="https://www.youtube.com/watch?v=RK1K2bCg4J8" for each video, it will work fine.

p.s. it is recommended to use normal href if user wants to open video in new tab for example.
p.s.s. readme.MD must be edited or this should be fixed.

@midzer
Copy link
Owner

midzer commented Jun 13, 2023

Can you have a closer look, @viliusle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants