Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PineFlash 0.5.5 #201676

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add PineFlash 0.5.5 #201676

wants to merge 4 commits into from
+51 −0

Conversation

parkerreno
Copy link

@parkerreno parkerreno commented Dec 23, 2024 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@parkerreno
Copy link
Author

@microsoft-github-policy-service agree

@parkerreno parkerreno mentioned this pull request Dec 23, 2024
Open
1 task
@parkerreno parkerreno marked this pull request as ready for review December 23, 2024 01:16
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 23, 2024
@stephengillie
Copy link
Collaborator

The application seemed to install correctly, but I couldn't get it to run when launched. This EXE gave an error:
image
Should VCRedist be a dependency?

Verify while here:
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Dec 23, 2024
@parkerreno
Copy link
Author

parkerreno commented Dec 23, 2024 via email •
edited by microsoft-github-policy-service bot
Loading

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 23, 2024
@parkerreno
Copy link
Author

Interesting - didn't run into that when doing sandbox validation. Will have to test on a fresh VM later. Will investigate.
…

Does look like blisp requires vcredist as mentioned - will add. Having launch issues on a fresh vm vs sandbox/ bare metal. Might be something driver related? Still looking.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 26, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 26, 2024
auto-merge was automatically disabled December 29, 2024 20:55

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Dec 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Changes-Requested Changes Requested New-Package labels Dec 29, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 30, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Dec 30, 2024 •
edited
Loading

Manual Validation ended with:
image

The application didn't appear to run - neither from the Start menu shortcut nor the command line. No logs were found in either the System nor Application logs, nor the application folder. Is this expected?

Edit:

Might be something driver related? Still looking.

Very possible. These are VMs downloaded with Hyper-V Quick Create, so are lacking robust audio and video drivers.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. New-Package Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: PineFlash
3 participants
@parkerreno @wingetbot @stephengillie