Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet test html logger throws execption when using special characters in DataRow attributes. #10431

Open
nohwnd opened this issue Nov 13, 2024 · 2 comments

Comments

@nohwnd
Copy link
Member

nohwnd commented Nov 13, 2024

Cannot move there, see: dotnet/sdk#38983

@daveMueller
Copy link
Contributor

Is it OK when I start working on that?

@daveMueller
Copy link
Contributor

I looked a bit into it and think this can only be solved by preprocessing the xml test result before transforming it into html. Like already mentioned in this comment here
https://github.com/microsoft/vstest/blob/main/src/Microsoft.TestPlatform.Extensions.HtmlLogger/HtmlTransformer.cs#L33-L35,
the test result can contain characters that aren't valid xml. Thus the html writer must also be tolerant of those characters which he isn't anymore after the change in this PR #4756.
But it also isn't an option to use own XmlWriterSettings again because this will bring back the staircase issue #4754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants