Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badly-formed hcDark default color for editorBracketHighlight.unexpectedBracket.foreground #237235

Open
andrewsuzuki opened this issue Jan 3, 2025 · 0 comments · May be fixed by #237236
Open

Badly-formed hcDark default color for editorBracketHighlight.unexpectedBracket.foreground #237235

andrewsuzuki opened this issue Jan 3, 2025 · 0 comments · May be fixed by #237236
Assignees
@aeschli

Comments

@andrewsuzuki
Copy link

Default value for hcDark in editorBracketHighlight.unexpectedBracket.foreground should be new Color(/* */), but it was accidentally wrapped in a string like 'new Color(/* */)'.

vscode/src/vs/editor/common/core/editorColorRegistry.ts

Line 83 in 2bdb3e9

export const editorBracketHighlightingUnexpectedBracketForeground = registerColor('editorBracketHighlight.unexpectedBracket.foreground', { dark: new Color(new RGBA(255, 18, 18, 0.8)), light: new Color(new RGBA(255, 18, 18, 0.8)), hcDark: 'new Color(new RGBA(255, 50, 50, 1))', hcLight: '#B5200D' }, nls.localize('editorBracketHighlightUnexpectedBracketForeground', 'Foreground color of unexpected brackets.'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andrewsuzuki @aeschli