From ba12a1c8e55c3ca8cca6679edb9cd2e5a08baa3d Mon Sep 17 00:00:00 2001 From: Aaron <105021049+apop5@users.noreply.github.com> Date: Thu, 19 Oct 2023 15:13:58 -0700 Subject: [PATCH] PolicyServicePkg: Adding MemoryAllocationLib to library classes that rely on it PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki --- PolicyServicePkg/Library/DxePolicyLib/DxePolicyLib.inf | 1 + PolicyServicePkg/Library/MmPolicyLib/MmPolicyLib.inf | 1 + PolicyServicePkg/Library/PeiPolicyLib/PeiPolicyLib.inf | 1 + 3 files changed, 3 insertions(+) diff --git a/PolicyServicePkg/Library/DxePolicyLib/DxePolicyLib.inf b/PolicyServicePkg/Library/DxePolicyLib/DxePolicyLib.inf index 9514705eccc..7b5b69cbf5c 100644 --- a/PolicyServicePkg/Library/DxePolicyLib/DxePolicyLib.inf +++ b/PolicyServicePkg/Library/DxePolicyLib/DxePolicyLib.inf @@ -30,6 +30,7 @@ [LibraryClasses] BaseLib DebugLib + MemoryAllocationLib UefiBootServicesTableLib [Protocols] diff --git a/PolicyServicePkg/Library/MmPolicyLib/MmPolicyLib.inf b/PolicyServicePkg/Library/MmPolicyLib/MmPolicyLib.inf index 3ff1aa35b59..d014951764d 100644 --- a/PolicyServicePkg/Library/MmPolicyLib/MmPolicyLib.inf +++ b/PolicyServicePkg/Library/MmPolicyLib/MmPolicyLib.inf @@ -29,6 +29,7 @@ BaseLib DebugLib MmServicesTableLib + MemoryAllocationLib [Protocols] gMmPolicyProtocolGuid ## CONSUMES diff --git a/PolicyServicePkg/Library/PeiPolicyLib/PeiPolicyLib.inf b/PolicyServicePkg/Library/PeiPolicyLib/PeiPolicyLib.inf index 329fbe051d4..abb23934449 100644 --- a/PolicyServicePkg/Library/PeiPolicyLib/PeiPolicyLib.inf +++ b/PolicyServicePkg/Library/PeiPolicyLib/PeiPolicyLib.inf @@ -28,6 +28,7 @@ [LibraryClasses] BaseLib DebugLib + MemoryAllocationLib [Ppis] gPeiPolicyPpiGuid ## CONSUMES