Why to add model & extraLibs to both JS & TS workers?

[manikantag]

Hi,

When creating model or adding extraLib, why should we need to add to both JavaScript & TypeScript workers? Isn't JS worker just TS worker internally? On top of my head, this is increasing the memory footprint, as the current API creates model & extraLibs from the source string.

This may be answered already, but I couldn't find any similar questions or references online.

Thanks

[hediet]

why should we need to add to both JavaScript & TypeScript workers?

What do you mean with need? Does the code currently do that or does your example not work if you don't do it?

[manikantag]

Please see this Playground link

I created an extraLib (Facts), a model (TsAnimal) for TS worker and one model (JsPerson) for JS worker. When you change the language, notice how the class defined in other language model doesn't recognized.

extraLib, which is added to TS worker, works fine in either language.

[hediet]

That's a good question.

I don't know the typescript language feature implementation, but it looks like this is just not supported.
You should be able though to easily clone the monaco editor and debug this!
We'd be open for small pull requests (unless they cause breaking changes).

[manikantag]

Thanks for confirmation. Sure, I'll do my best.

[hediet]

Please look in Contributing.md and let me know about your debugging experience. I recently made improvements there with the hope that it will be easier for the community to investigate the bugs/feature requests they find.

[manikantag]

I stand corrected: extraLib also doesn't work always. Still needs to add to respective worker.

In the above playground link, I was also creating the model from the definitions.

Fixed playground link

[manikantag]

I'll document my findings & progress here:

Some discussion about separate workers: microsoft/monaco-typescript#8 (comment)