Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitk: check main window visibility before waiting for it to show #704

Closed
Dieken opened this issue Nov 8, 2024 · 1 comment · Fixed by #705
Closed

gitk: check main window visibility before waiting for it to show #704

Dieken opened this issue Nov 8, 2024 · 1 comment · Fixed by #705

Comments

@Dieken
Copy link

Dieken commented Nov 8, 2024

Please apply patch at git#944 , without this patch gitk will hang forever on macOS.

Reference: https://github.com/Homebrew/homebrew-core/pull/68865/files

@dscho
Copy link
Member

dscho commented Nov 12, 2024

Please apply patch at git#944 ,

@Dieken please open a PR.

dscho added a commit that referenced this issue Nov 13, 2024
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
mjcheetham pushed a commit that referenced this issue Dec 3, 2024
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
dscho added a commit that referenced this issue Dec 17, 2024
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
dscho added a commit that referenced this issue Dec 18, 2024
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
dscho added a commit that referenced this issue Dec 18, 2024
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
dscho added a commit that referenced this issue Dec 19, 2024
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants