netsh ebpf show verif should verify all sections #4154
Draft
+126
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Thaler <[email protected]>
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
changed the title
_ebpf_api_elf_verify_program_from_stream() was passing a possibly NULL stats pointer to ebpf_verify_program() which would dereference it and crash. Signed-off-by: Dave Thaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3884
This PR also fixes an issue uncovered by adding more SAL annotations. Specifically, _ebpf_api_elf_verify_program_from_stream() was passing a possibly NULL stats pointer to ebpf_verify_program() which would dereference it and crash.
Testing
Added a new unit test to run "show verif" on bindmonitor_bpf2bpf.c which has multiple programs and sections
Documentation
No impact.
Installation
No impact.