Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink packaging: split mlos_bench.storage out? #947

Open
bpkroth opened this issue Jan 29, 2025 · 0 comments
Open

Rethink packaging: split mlos_bench.storage out? #947

bpkroth opened this issue Jan 29, 2025 · 0 comments
Labels
design Design doc discussions

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Jan 29, 2025

A small observation while thinking about #944 and #838 and #732:

With multiple component nodes in this design, not all of them need all of the different parts of MLOS installed.

  • mlos_benchd_service needs mlos_bench.storage and mlos_bench which likely needs mlos_core
  • mlos_viz needs mlos_bench.storage but that's all
  • mlos_webui needs mlos_viz and mlos_bench.storage

We may want to extract out the mlos_bench.storage portion to its own package somehow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design doc discussions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bpkroth