Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Add support for writing a secret (HMACSHA256) in the blob and deserializer #39

Open
mjsabby opened this issue Jul 17, 2019 · 0 comments

Comments

@mjsabby
Copy link
Contributor

mjsabby commented Jul 17, 2019

Add an option (probably it'll be the default) that allows writing an HMACSHA256 secret in the blob and support two options to provide the secret to the deserializer. Option 1 is that the assembly will have the secret embedded in it, and therefore the assembly itself must be guarded as a secret. And Option 2 will be that the deserializer will have an overload that takes in the secret as a `ReadOnlySpan'.

From a security perspective, it'll obviously be Option 2 that is desired but I feel like we should allow Option 1 and if we want to call it insecure that's fine and it can be used encode identity info in an untrusted manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant