Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enablement of Trusted Launch and vTPM for VMs #4235

Open
3 tasks
jonnyry opened this issue Dec 31, 2024 · 0 comments
Open
3 tasks

Allow enablement of Trusted Launch and vTPM for VMs #4235

jonnyry opened this issue Dec 31, 2024 · 0 comments
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@jonnyry
Copy link
Collaborator

jonnyry commented Dec 31, 2024

Description

As a TRE Administrator/TRE Developer
I want to be able to enable Trusted Launch and vTPM for Virtual Machines
So that I can benefit from the additional security that these features provide.

For Guacamole VMs, these options should be set on a per image basis, rather than for all images, since some images may not support these settings.

Acceptance criteria

  • Ability to set secure_boot_enabled on a per image basis
  • Ability to set vtpm_enabled on a per image basis
  • Ignore updates to these values for existing VMs since changing this option in terraform is currently a destructive action. (This may change in future - see this azurerm provider issue)

Trusted Launch & vTPM in Azure Portal

Image

Suggested solution for Guacamole VMs

It would be desirable if configuration could be done via deploy time variables in order to reduce forked code change, however given most users are running custom VMs and this requires editing of the porter.yaml file anyway, the configuration values could be set here, e.g.

  image_options:
    "Windows 10":
      source_image_reference:
        publisher: MicrosoftWindowsDesktop
        offer: Windows-10
        sku: win10-22h2-pro-g2
        version: latest
      conda_config: false
      secure_boot_enabled: true
      vtpm_enabled: true
    "Windows 3.1.1 For Workgroups (Custom image)":
      source_image_name: win-3-1-1-workgroups
      conda_config: false
      secure_boot_enabled: false
      vtpm_enabled: false
@jonnyry jonnyry added the story Stories are the smallest unit of work to be done for a project. label Dec 31, 2024
@jonnyry jonnyry changed the title Allow enablement of Trused Launch and vTPM for Guacamole VMs Allow enablement of Trusted Launch and vTPM for Guacamole VMs Dec 31, 2024
@jonnyry jonnyry changed the title Allow enablement of Trusted Launch and vTPM for Guacamole VMs Allow enablement of Trusted Launch and vTPM for VMs Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Development

No branches or pull requests

1 participant