Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeSEs: improve #357

Open
TuomasBorman opened this issue Apr 4, 2023 · 2 comments
Open

mergeSEs: improve #357

TuomasBorman opened this issue Apr 4, 2023 · 2 comments

Comments

@TuomasBorman
Copy link
Contributor

Add parallelization to the method. Also, add option for choosing whether to combine colData columns even though their classes differ

Currently, the method checks if equally named columns have same class --> if not, do not merge. (There could be an option that allows method to merge columns even though they have different class)

@antagomir
Copy link
Member

Also consider renaming mergeSEs -> combineSEs since now we are also using merge for row/col agglomeration.

@Daenarys8
Copy link
Collaborator

mergeSEs is mostly sequential with the shared tse and the output of one loop is the input of the next during the merge. I am not sure of how we can apply bplapply to it's operation.
Also during this deprecation -->> combineSEs, can we remove completely all the deprecation as bioc 3.20 is in release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants