Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbind metrics that are no longer relevant #21

Open
phijor opened this issue Feb 9, 2021 · 2 comments · May be fixed by #39
Open

Unbind metrics that are no longer relevant #21

phijor opened this issue Feb 9, 2021 · 2 comments · May be fixed by #39
Labels
enhancement New feature or request question Further information is requested

Comments

@phijor
Copy link
Contributor

phijor commented Feb 9, 2021

metricq-manager/metricq_manager/manager.py

Line 407 in 7f96854

# TODO unbind other metrics that are no longer relevant

Do we want to unbind all metrics that are not given in the current set of bindings?
@phijor phijor added enhancement New feature or request question Further information is requested labels Feb 9, 2021
@phijor phijor mentioned this issue Feb 9, 2021
Merged
5 tasks
@tilsche
Copy link
Contributor

tilsche commented Feb 9, 2021

Yeah, sure we do. But we don't get that list from AMQP, right?

@phijor
Copy link
Contributor Author

phijor commented Feb 9, 2021

Correct, AMQP does not provide these.

@bmario bmario linked a pull request Jun 3, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup unused bindings for DB metricq/metricq-manager
2 participants
@tilsche @phijor