Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HTTP API DoS / No backoff on API failures #121

Open
broglep opened this issue Jan 5, 2025 · 0 comments
Open

[Bug]: HTTP API DoS / No backoff on API failures #121

broglep opened this issue Jan 5, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@broglep
Copy link

broglep commented Jan 5, 2025

Hardware

Not Applicable

Connection Type

HTTP

Firmware Version

Description

The code constantly performs new HTTP API calls even if they have failed. There seems to be no time in between requests and this essential performs an denial of service to the API. This has been observed using the web interface (meshtastic/web#361). At first sight on the code, there should be a delay / fetch interval but I did not observe such a delay in the browser app.

There should be some delay after failed request, ideally an exponential backoff and maybe even treat 4xx and 5xx differently. For 4xx response codes it is unlikely that retrying will help anything, so connection should stop. For 5xx response codes the API call can be retried after some backoff

Relevant console output

No response

@broglep broglep added the bug Something isn't working label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant