Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meom code clinic] tests #70

Closed
rcaneill opened this issue Jul 15, 2024 · 4 comments
Closed

[meom code clinic] tests #70

rcaneill opened this issue Jul 15, 2024 · 4 comments
Assignees

Comments

@rcaneill
Copy link

This issue is open for the MEOM internal code clinic / review process

@rcaneill
Copy link
Author

tests

  • The package has tests:
    • Tests cover essential functions of the package and a reasonable range of inputs and conditions.
  • Continuous Integration: Has continuous integration setup (We suggest using Github actions but any CI platform is acceptable for review)

@auraoupa
Copy link
Member

  • The package has tests: yes
    • Tests cover essential functions of the package and a reasonable range of inputs and conditions.

The package has a test directory in which 1 test case is described (gaussian_eddy.py) and tested (test_velocities.py)
Maybe another different test case could be implemented and some unit tests on some simple functions defined in tools for instance could be implemented

  • Continuous integration : yes with github action, each time a push or a pull request is done on main it is triggering the running of the test case

@lesommer
Copy link
Member

See issues #79

@lesommer
Copy link
Member

Now closing code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants