Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program encodes some unnecessary files even with skipUnknown #5

Open
TadeLn opened this issue Feb 14, 2024 · 4 comments
Open

Program encodes some unnecessary files even with skipUnknown #5

TadeLn opened this issue Feb 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@TadeLn
Copy link

TadeLn commented Feb 14, 2024

If you have a file named album_foobar.png in the song folder, it will still be included in the .sng file, even with the --skipUnknown option. This is also the case for highways, backgrounds, and videos.

I'm not really sure if this is a bug or intended behavior, but it seems like a bug.

The bug seems to be here. The filename is checked with StartsWith instead of checking the whole filename up to the last .

@mdsitton
Copy link
Owner

I'd say this is a bug yes, thanks for the report. i'll get this fixed soon

@mdsitton mdsitton added the bug Something isn't working label Feb 16, 2024
@TadeLn
Copy link
Author

TadeLn commented Feb 16, 2024

I just found out that CH allows for multiple backgrounds apparently, so I think this behavior is fine for background images, but it shouldn't be the case for album art. I don't know what about highways and background videos, I can't check that right now... I'll check it in a few hours when I get home.

@TadeLn
Copy link
Author

TadeLn commented Feb 16, 2024

Okay, checked with CH v1.1.0 PTB:

  • Album art: only a single file named album (with the correct file extension) works
  • Background videos: only a single file named video (with the correct file extension) works
  • Highways: only a single file named highway (with the correct file extension) works
  • Background images: multiple files are allowed, the game chooses randomly from one of the files named background* (with the correct file extension) where * is anything (including nothing)

Which means that this bug should be fixed for album arts, videos, and highways, but backgrounds work fine currently.

@mdsitton
Copy link
Owner

I just found out that CH allows for multiple backgrounds apparently, so I think this behavior is fine for background images, but it shouldn't be the case for album art. I don't know what about highways and background videos, I can't check that right now... I'll check it in a few hours when I get home.

Yes that is true but for ch such backgrounds have to contain background (casing doesn't matter) in the filename for it to be considered as a background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants