-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program encodes some unnecessary files even with skipUnknown #5
Comments
I'd say this is a bug yes, thanks for the report. i'll get this fixed soon |
I just found out that CH allows for multiple backgrounds apparently, so I think this behavior is fine for background images, but it shouldn't be the case for album art. I don't know what about highways and background videos, I can't check that right now... I'll check it in a few hours when I get home. |
Okay, checked with CH v1.1.0 PTB:
Which means that this bug should be fixed for album arts, videos, and highways, but backgrounds work fine currently. |
Yes that is true but for ch such backgrounds have to contain background (casing doesn't matter) in the filename for it to be considered as a background. |
If you have a file named
album_foobar.png
in the song folder, it will still be included in the .sng file, even with the--skipUnknown
option. This is also the case for highways, backgrounds, and videos.I'm not really sure if this is a bug or intended behavior, but it seems like a bug.
The bug seems to be here. The filename is checked with StartsWith instead of checking the whole filename up to the last
.
The text was updated successfully, but these errors were encountered: