Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI and test against different Node versions #9

Open
grabbou opened this issue Sep 21, 2015 · 2 comments
Open

Set up CI and test against different Node versions #9

grabbou opened this issue Sep 21, 2015 · 2 comments

Comments

@grabbou
Copy link

grabbou commented Sep 21, 2015

There are reports that it might have broken with Node 4.0 although haven't checked that personally yet. A simple test-case would be much appreciated, CC: @XeeD

@mntnoe
Copy link

mntnoe commented Sep 23, 2015

CI would be non-trivial to set up, given the nature of piping. Perhaps a shell script doing something like the following:

  • Create a JS file using piping that outputs 'a'.
  • Run the file in background, and expect the output to be 'a'.
  • Modify the JS file to output 'b'
  • Expect the output to be 'b'.
  • Kill the process.

As piping is only meant to be used in a development environment, I doubt CI is much needed, though; especially if node.js is actually moving to semver.

I briefly tested piping on Windows using Node 4.0, and it seems to work. Do you have more details on what is broken?

@grabbou
Copy link
Author

grabbou commented Sep 23, 2015

Sorry, that was a false alarm from @XeeD and it actually seems to work w/o issues. Even if it's for development, I guess a general test to check if it still reloads would be a nice addition. The suggested behaviour sounds good enough to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants