From c99128f6cd29705454a73dc09023d7602fa2d43f Mon Sep 17 00:00:00 2001 From: Kimball Bighorse Date: Wed, 27 Jul 2022 00:02:41 -0700 Subject: [PATCH 1/3] Ignore `unloadable` if method missing See: https://github.com/github/graphql-client/pull/274 --- app/controllers/plutus/entries_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/plutus/entries_controller.rb b/app/controllers/plutus/entries_controller.rb index 97781ab5..29b287df 100644 --- a/app/controllers/plutus/entries_controller.rb +++ b/app/controllers/plutus/entries_controller.rb @@ -11,7 +11,7 @@ module Plutus # # @author Michael Bulat class EntriesController < Plutus::ApplicationController - unloadable + unloadable if respond_to?(:unloadable) # @example # GET /entries # GET /entries.xml From a7b76693d6b8beed242e1c5b684893a01b08bb29 Mon Sep 17 00:00:00 2001 From: Kimball Bighorse Date: Wed, 27 Jul 2022 00:18:33 -0700 Subject: [PATCH 2/3] Move unloadable logic up to application controller --- app/controllers/plutus/application_controller.rb | 1 + app/controllers/plutus/entries_controller.rb | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/plutus/application_controller.rb b/app/controllers/plutus/application_controller.rb index be15dddc..7f1735cd 100644 --- a/app/controllers/plutus/application_controller.rb +++ b/app/controllers/plutus/application_controller.rb @@ -1,4 +1,5 @@ module Plutus class ApplicationController < ActionController::Base + unloadable if respond_to?(:unloadable) end end diff --git a/app/controllers/plutus/entries_controller.rb b/app/controllers/plutus/entries_controller.rb index 29b287df..c853eb2e 100644 --- a/app/controllers/plutus/entries_controller.rb +++ b/app/controllers/plutus/entries_controller.rb @@ -11,7 +11,6 @@ module Plutus # # @author Michael Bulat class EntriesController < Plutus::ApplicationController - unloadable if respond_to?(:unloadable) # @example # GET /entries # GET /entries.xml From 53c16d58cb95c3c2d04eb4377051ca86be9b071f Mon Sep 17 00:00:00 2001 From: Kimball Bighorse Date: Wed, 27 Jul 2022 00:20:45 -0700 Subject: [PATCH 3/3] Remove redundant `unloadable` calls in subclasses --- app/controllers/plutus/accounts_controller.rb | 2 -- app/controllers/plutus/reports_controller.rb | 2 -- 2 files changed, 4 deletions(-) diff --git a/app/controllers/plutus/accounts_controller.rb b/app/controllers/plutus/accounts_controller.rb index 17cb6a81..08972100 100644 --- a/app/controllers/plutus/accounts_controller.rb +++ b/app/controllers/plutus/accounts_controller.rb @@ -11,8 +11,6 @@ module Plutus # # @author Michael Bulat class AccountsController < ::Plutus::ApplicationController - unloadable - # @example # GET /accounts # GET /accounts.xml diff --git a/app/controllers/plutus/reports_controller.rb b/app/controllers/plutus/reports_controller.rb index 323947dd..622788f6 100644 --- a/app/controllers/plutus/reports_controller.rb +++ b/app/controllers/plutus/reports_controller.rb @@ -6,8 +6,6 @@ module Plutus # # @author Michael Bulat class ReportsController < ::Plutus::ApplicationController - unloadable - # @example # GET /reports/balance_sheet def balance_sheet