Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand_relative_paths has to be set before parse is called. #190

Open
mbakeranalecta opened this issue Apr 20, 2018 · 0 comments
Open

expand_relative_paths has to be set before parse is called. #190

mbakeranalecta opened this issue Apr 20, 2018 · 0 comments
Labels

Comments

@mbakeranalecta
Copy link
Owner

If you set expand_relative_paths on the parser after calling samParser.parse, it will have no effect. This is because it gets passed to the DocStructure object when it is created.

Probably not a good idea to have expand_relative_paths be a property of the doc structure at all. But then have to deal with the fact that the doc structure is only created when the parse method is called. Maybe that should change too, so that the doc object is created when the parser is created, allowing us to immediately set properties on it.

Alternatively, if it seems like the properties intuitively belong to the parser, maybe we need to let them be read from block in the doc structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant