Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landcodes, waarom niet aanhouden van ISO 3166? #311

Open
alextreme opened this issue Dec 20, 2024 · 1 comment · May be fixed by #317
Open

Landcodes, waarom niet aanhouden van ISO 3166? #311

alextreme opened this issue Dec 20, 2024 · 1 comment · May be fixed by #317
Assignees
@danielmursa-dev
Labels
approved enhancement New feature or request owner: den-haag

Comments

@alextreme
Copy link
Member

Thema / Theme

Klantinteracties API

Omschrijving / Description

Bij een Partij is nu een 4-teken landcode veld opgenomen voor buitenlandse adressen

Waarom wordt hier niet de ISO 3166 standaard aangehouden? 2 tekens en validatie hierop zou voldoende moeten zijn in plaats van een eigen landenlijst aanhouden

Toegevoegde waarde / Added value

No response

Aanvullende opmerkingen / Additional context

No response
@joeribekker joeribekker removed the triage label Jan 6, 2025
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Jan 6, 2025
@joeribekker
Copy link
Member

Approved by Alex-proxy due to prio.

@danielmursa-dev danielmursa-dev moved this from Todo to In Progress in Data en API fundament Jan 9, 2025
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Add country dict
76835fe
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Update models + migrations
b343f08
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Create Tests
32f6164
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Fix Tests
e442bb0
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Upgrade migration
29fba52
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Test migration
bdfe9eb
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Isort and flake
48ae0ff
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Upgrade migration
88d050a
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Fix naming
31fd0f7
@danielmursa-dev danielmursa-dev linked a pull request Jan 10, 2025 that will close this issue
Open
@danielmursa-dev danielmursa-dev moved this from In Progress to Implemented in Data en API fundament Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmursa-dev danielmursa-dev

Labels
approved enhancement New feature or request owner: den-haag
Projects
Data en API fundament
Status: Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/311 validation country code maykinmedia/open-klant
3 participants
@joeribekker @alextreme @danielmursa-dev