-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#148] Update liveness probes #164
Open
SilviaAmAm
wants to merge
9
commits into
main
Choose a base branch
from
feature/148-liveness-probes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+283
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAB has long running tasks (>2h), so only the celery active probe is added
The object API has a celerty task limit of 5 min (soft), 15 min (hard). So no ping was added.
SilviaAmAm
force-pushed
the
feature/148-liveness-probes
branch
from
January 10, 2025 14:43
9829933
to
f484d0e
Compare
Open forms has task limits (5 (soft), 15 (hard) minutes) so no ping was added
OIP has a hard task limit of 15 min, so no ping probe was added
Timeouts added in maykinmedia/open-klant#316
Open Zaak has one long running tasks of which we don't know how long it will take, so no ping probe was added. The task: https://github.com/open-zaak/open-zaak/blob/70449f11a31a0e8a06d9e47d49e095b31d1068f6/src/openzaak/components/documenten/tasks.py#L333
SilviaAmAm
force-pushed
the
feature/148-liveness-probes
branch
from
January 10, 2025 14:49
f484d0e
to
d1f1bfe
Compare
Is to be verified first on our test-cluster before approval/merging |
Yes, I agree with the testing on our cluster. I will try to do it. |
Deployed on our test cluster:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148