Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#148] Update liveness probes #164

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

SilviaAmAm
Copy link
Collaborator

Fixes #148

@SilviaAmAm SilviaAmAm marked this pull request as draft January 10, 2025 14:42
OAB has long running tasks (>2h), so only the celery active probe is added
The object API has a celerty task limit of 5 min (soft), 15 min (hard). So no ping was added.
@SilviaAmAm SilviaAmAm force-pushed the feature/148-liveness-probes branch from 9829933 to f484d0e Compare January 10, 2025 14:43
Open forms has task limits (5 (soft), 15 (hard) minutes) so no ping was added
OIP has a hard task limit of 15 min, so no ping probe was added
Open Zaak has one long running tasks of which we don't know how long it
will take, so no ping probe was added.

The task: https://github.com/open-zaak/open-zaak/blob/70449f11a31a0e8a06d9e47d49e095b31d1068f6/src/openzaak/components/documenten/tasks.py#L333
@SilviaAmAm SilviaAmAm force-pushed the feature/148-liveness-probes branch from f484d0e to d1f1bfe Compare January 10, 2025 14:49
@SilviaAmAm SilviaAmAm marked this pull request as ready for review January 10, 2025 14:51
@alextreme
Copy link
Member

Is to be verified first on our test-cluster before approval/merging

@Tiho0135
Copy link

Yes, I agree with the testing on our cluster. I will try to do it.

@SilviaAmAm
Copy link
Collaborator Author

SilviaAmAm commented Jan 10, 2025

Deployed on our test cluster:

  • Objecten
  • OAB
  • Open Forms
  • OIP
  • Open Klant
  • Open notificaties
  • Openzaak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery worker fix liveness check
3 participants