You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Link to email is missing http:// and now contains an absolute path that fails.
Consider: in 1.4, the files listed could be wrapped in ticks for inline code blocks.
In 2.2, you should consider talking about {'\n'}.
2.3: "Try changing textAlign to left instead of centercenter"
2.3: Put a note at the bottom explaining that for people familiar with CSS that React CSS is a subset of regular CSS, and that the properties have different names (eg textAlign as opposed to text-align), and link to the React CSS docs.
Similarly, in 2.5, you should mention why you need {} to inject variables into the HTML, and maybe mention that for the <Image> tag, the source attribute has a JavaScript object as it's value. (the {{}} is a bit confusing).
In 3.3, super confused about what the following does:
Mostly the => statements. What do they do? Where did you declare the response variable? Is this fancy javascript stuff that I'm not familiar with? Or react specific? Either way I would definitely explain what's going on there.
In 3.3, responseData.items is going to be magic (unless you want to link to a JSON call and show them) but that might be okay.
4.1: Add a code block showing the changes to the list of components. (otherwise I'm sure people will forget to do it, even with the NOTE.
4.1: You might explain React state a little more, saying that it's an object, but in order to change it, you have to have initial values, or something like that.
Again, the => in 4.1
4.2: Not sure I like the turnery operator here... an if/else chain would be much more clear.
Conclusion: change the block comment to be your name, a link to the tutorial, and say it was adapted from the Sample React Native App.
Great stuff!
The text was updated successfully, but these errors were encountered:
Link to email is missing
http://
and now contains an absolute path that fails.Consider: in 1.4, the files listed could be wrapped in ticks for inline code blocks.
In 2.2, you should consider talking about
{'\n'}
.2.3: "Try changing
textAlign
toleft
instead ofcentercenter
"2.3: Put a note at the bottom explaining that for people familiar with CSS that React CSS is a subset of regular CSS, and that the properties have different names (eg
textAlign
as opposed totext-align
), and link to the React CSS docs.Similarly, in 2.5, you should mention why you need
{}
to inject variables into the HTML, and maybe mention that for the<Image>
tag, thesource
attribute has a JavaScript object as it's value. (the{{}}
is a bit confusing).In 3.3, super confused about what the following does:
Mostly the
=>
statements. What do they do? Where did you declare theresponse
variable? Is this fancy javascript stuff that I'm not familiar with? Or react specific? Either way I would definitely explain what's going on there.In 3.3,
responseData.items
is going to be magic (unless you want to link to a JSON call and show them) but that might be okay.4.1: Add a code block showing the changes to the list of components. (otherwise I'm sure people will forget to do it, even with the NOTE.
4.1: You might explain React state a little more, saying that it's an object, but in order to change it, you have to have initial values, or something like that.
Again, the
=>
in 4.14.2: Not sure I like the turnery operator here... an if/else chain would be much more clear.
Conclusion: change the block comment to be your name, a link to the tutorial, and say it was adapted from the Sample React Native App.
Great stuff!
The text was updated successfully, but these errors were encountered: