Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #1

Open
schlosser opened this issue Apr 14, 2015 · 0 comments
Open

Comments #1

schlosser opened this issue Apr 14, 2015 · 0 comments

Comments

@schlosser
Copy link

  • Link to email is missing http:// and now contains an absolute path that fails.

  • Consider: in 1.4, the files listed could be wrapped in ticks for inline code blocks.

  • In 2.2, you should consider talking about {'\n'}.

  • 2.3: "Try changing textAlign to left instead of center center"

  • 2.3: Put a note at the bottom explaining that for people familiar with CSS that React CSS is a subset of regular CSS, and that the properties have different names (eg textAlign as opposed to text-align), and link to the React CSS docs.

  • Similarly, in 2.5, you should mention why you need {} to inject variables into the HTML, and maybe mention that for the <Image> tag, the source attribute has a JavaScript object as it's value. (the {{}} is a bit confusing).

  • In 3.3, super confused about what the following does:

    .then((response) = > response.json())
    .then((responseData => {
    ...

    Mostly the => statements. What do they do? Where did you declare the response variable? Is this fancy javascript stuff that I'm not familiar with? Or react specific? Either way I would definitely explain what's going on there.

  • In 3.3, responseData.items is going to be magic (unless you want to link to a JSON call and show them) but that might be okay.

  • 4.1: Add a code block showing the changes to the list of components. (otherwise I'm sure people will forget to do it, even with the NOTE.

  • 4.1: You might explain React state a little more, saying that it's an object, but in order to change it, you have to have initial values, or something like that.

  • Again, the => in 4.1

  • 4.2: Not sure I like the turnery operator here... an if/else chain would be much more clear.

  • Conclusion: change the block comment to be your name, a link to the tutorial, and say it was adapted from the Sample React Native App.

Great stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant