Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot uploaded to S3 using cucumber reporting local file paths #244

Open
garytaylor opened this issue Nov 20, 2018 · 1 comment
Open
Labels

Comments

@garytaylor
Copy link

I have looked into this and have made the following "Monkey Patch" in my code. It appears that the S3 saver does not have the output_screenshot_path method defined so it calls the method on the non S3 saver and gets it wrong.

Here is my code

module Capybara
  module Screenshot
    class S3Saver
      def output_screenshot_path
        output "HTML screenshot: #{html_path}" if html_saved?
        output "Image screenshot: #{screenshot_path}" if screenshot_saved?
      end
    end
  end
end

which works a treat :-) but unsure if it will have any impact on the rspec output or any other area where it shouldnt

@mattheworiordan
Copy link
Owner

Thanks for reporting this @garytaylor. Fancy rolling that patch up into a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants