From 3fe38a31ba792b87d765843ac84afa914519a9a8 Mon Sep 17 00:00:00 2001 From: kshitij katiyar Date: Tue, 12 Nov 2024 15:51:31 +0530 Subject: [PATCH 1/2] upgraded golangci-lint version from 1.51.1 to 1.55.0 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 191a9eaf..71cfa14d 100644 --- a/Makefile +++ b/Makefile @@ -158,7 +158,7 @@ apply: ## Install go tools install-go-tools: @echo Installing go tools - $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.1 + $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.0 $(GO) install gotest.tools/gotestsum@v1.7.0 ## Runs eslint and golangci-lint From 679b32b940fca135e991a03709a04fe5900f3ad7 Mon Sep 17 00:00:00 2001 From: kshitij katiyar Date: Tue, 12 Nov 2024 16:30:27 +0530 Subject: [PATCH 2/2] updated the mainfest to remove duplicate string usage --- build/manifest/main.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/build/manifest/main.go b/build/manifest/main.go index c57fe107..30486400 100644 --- a/build/manifest/main.go +++ b/build/manifest/main.go @@ -10,6 +10,8 @@ import ( "github.com/pkg/errors" ) +const stringFormatter = `%s` + const pluginIDGoFileTemplate = `// This file is automatically generated. Do not modify it manually. package main @@ -23,9 +25,7 @@ import ( var manifest *model.Manifest -const manifestStr = ` + "`" + ` -%s -` + "`" + ` +const manifestStr = ` + "`" + stringFormatter + "`" + ` func init() { _ = json.NewDecoder(strings.NewReader(manifestStr)).Decode(&manifest) @@ -34,9 +34,7 @@ func init() { const pluginIDJSFileTemplate = `// This file is automatically generated. Do not modify it manually. -const manifest = JSON.parse(` + "`" + ` -%s -` + "`" + `); +const manifest = JSON.parse(` + "`" + stringFormatter + "`" + `); export default manifest; `