Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old method names using names from parsimony-plateau paper #21

Open
willdumm opened this issue Jul 1, 2022 · 0 comments
Open

Fix old method names using names from parsimony-plateau paper #21

willdumm opened this issue Jul 1, 2022 · 0 comments

Comments

@willdumm
Copy link
Collaborator

willdumm commented Jul 1, 2022

Lots of method names are poorly chosen, and do not match the terminology later chosen in the parsimony-plateau paper. Here are some examples

under_clade should be clade_union
partitions -> child_clades
is_root -> is_ua_node
node_self -> empty_copy
clade tree -> history
get_trees -> get_histories
count_trees -> count_histories
is_clade_tree -> is_history
_get_subtree_by_id -> _get_subhistory_by_id
_get_clade_tree -> _get_subhistory
utils._cladetree_method -> utils._history_method
postorder_cladetree_accum -> postorder_history_accum

Exposed methods which require renaming will be preserved, with the old name calling the method with the new name. These old method names preserved for compatibility should be ignored in the documentation, and should no longer be called by any internal code.

@willdumm willdumm mentioned this issue Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant