Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API request: load a media timeline from a specific event #4554

Closed
bmarty opened this issue Jan 20, 2025 · 6 comments · Fixed by #4561
Closed

API request: load a media timeline from a specific event #4554

bmarty opened this issue Jan 20, 2025 · 6 comments · Fixed by #4561

Comments

@bmarty
Copy link
Contributor

bmarty commented Jan 20, 2025

The app needs to be able to load a media timeline from a specific event, to be able to navigate through media using the swipe gesture.

Currently we have an API Room.messageFilteredTimeline that returns a timeline.

A possible solution could be to add an optional eventId parameter to this method.

@bnjbvr
Copy link
Member

bnjbvr commented Jan 20, 2025

Hi! the timeline created with permalinks does exactly that, right?

@bmarty
Copy link
Contributor Author

bmarty commented Jan 20, 2025

Yes, in this case, the API is Room.timelineFocusedOnEvent. So we need a bit of a mix of the 2 APIs.

@bnjbvr
Copy link
Member

bnjbvr commented Jan 20, 2025

Oh you're talking only about an FFI-layer API for this, aren't you?

@bmarty
Copy link
Contributor Author

bmarty commented Jan 20, 2025

Yes, this is the only API the application is aware of.

@bnjbvr
Copy link
Member

bnjbvr commented Jan 21, 2025

Ok, that makes sense. Please add details in your issue next time that this is for the FFI layer. Out of context, this was a bit hard to understand (especially since all the APIs already exist in the SDK, maybe not at the FFI layer). The "application" isn't our only use case.

@bmarty
Copy link
Contributor Author

bmarty commented Jan 21, 2025

Will do, thanks. I thought that linking the user story (element-hq/element-meta#2698) was enough to give context, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants