Limit the processing time of archiving jobs #22979
Open
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
force-pushed
the
dev-18891
branch
2 times, most recently
from
47cd244 to
b18fcb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Archiving jobs are supposed to be started at least once a day to ensure that invalidations are correctly processed.
To ensure jobs are not stuck in long running invalidations, preventing the system from starting new jobs and creating invalidations this PR introduces a configurable time limit per job.
The time limit can be set by using the parameter
--stop-processing-after=The default value for now is set to 24 hours. If for any reason longer running jobs are needed, a value of
-1can be provided.fixes #22973
Review