Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Problems with concurrent-archivers #22965

Closed
4 tasks done
vafhornung opened this issue Jan 22, 2025 · 1 comment
Closed
4 tasks done

[Bug] Problems with concurrent-archivers #22965

vafhornung opened this issue Jan 22, 2025 · 1 comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member

Comments

@vafhornung
Copy link

What happened?

You have fixed (and effective enabled) a non-working Matomo 5.0.0 feature, the option concurrent-archivers (default set to 3), silently in the Matomo update 5.2.0 (nothing mentioned in the changelogs), see #22508.

This change has disrupted our Jenkins scheduling by stopping Matomo archiving jobs. The issue stems from aborted runs returning an exit code of 0, which Jenkins interprets as successful. As a result, the jobs appear to have completed successfully, but in reality, they were not executed.

I attempted to disable concurrent-archivers by setting --concurrent-archivers -1 as specified in the documentation, but it did not work.
Here's the error I encountered:

In ArgvInput.php line 205:

  [Symfony\Component\Console\Exception\RuntimeException]
  The "-1" option does not exist.

It appears that using --concurrent-archivers 0 effectively disables the check, however, this behavior is undocumented, and I am unsure if it might lead to other issues.

Could you please investigate and address this issue?

Thank you in advance!

What should happen?

Reached maximum concurrent archivers allowed (3), aborting run.
Should not exit with 0.

--concurrent-archivers -1 should be handled as documented

How can this be reproduced?

Run

php console core:archive -vvv --concurrent-archivers -1

Matomo version

5.2.1

PHP version

PHP 8.3

Server operating system

Debian Bookworm

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

Validations

@vafhornung vafhornung added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 22, 2025
@sgiehl
Copy link
Member

sgiehl commented Jan 27, 2025

@vafhornung To set the value correctly you need to use --concurrent-archivers=-1. Otherwise the console will detect -1 as a flag instead of the value for the previous one

@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member
Projects
None yet
Development

No branches or pull requests

2 participants