From 555629e691c34ada0a7081e798a3a6f8815b33d2 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Tue, 14 Jan 2025 15:38:27 -0500 Subject: [PATCH] Add error ID arrow:io:ipc:InvalidConstructionType. --- matlab/src/cpp/arrow/matlab/error/error.h | 1 + .../arrow/matlab/io/ipc/proxy/record_batch_stream_reader.cc | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/matlab/src/cpp/arrow/matlab/error/error.h b/matlab/src/cpp/arrow/matlab/error/error.h index 425e089d9f2f9..729e0f1d05039 100644 --- a/matlab/src/cpp/arrow/matlab/error/error.h +++ b/matlab/src/cpp/arrow/matlab/error/error.h @@ -247,6 +247,7 @@ static const char* IPC_RECORD_BATCH_WRITE_FAILED = static const char* IPC_RECORD_BATCH_WRITE_CLOSE_FAILED = "arrow:io:ipc:CloseFailed"; static const char* IPC_RECORD_BATCH_READER_OPEN_FAILED = "arrow:io:ipc:FailedToOpenRecordBatchReader"; +static const char* IPC_RECORD_BATCH_READER_INVALID_CONSTRUCTION_TYPE = "arrow:io:ipc:InvalidConstructionType"; static const char* IPC_RECORD_BATCH_READ_INVALID_INDEX = "arrow:io:ipc:InvalidIndex"; static const char* IPC_RECORD_BATCH_READ_FAILED = "arrow:io:ipc:ReadFailed"; static const char* IPC_TABLE_READ_FAILED = "arrow:io:ipc:TableReadFailed"; diff --git a/matlab/src/cpp/arrow/matlab/io/ipc/proxy/record_batch_stream_reader.cc b/matlab/src/cpp/arrow/matlab/io/ipc/proxy/record_batch_stream_reader.cc index 74dacb3beb614..259f0271a9467 100644 --- a/matlab/src/cpp/arrow/matlab/io/ipc/proxy/record_batch_stream_reader.cc +++ b/matlab/src/cpp/arrow/matlab/io/ipc/proxy/record_batch_stream_reader.cc @@ -86,11 +86,10 @@ libmexclass::proxy::MakeResult RecordBatchStreamReader::make( const auto type_utf16 = std::u16string(type_mda[0]); if (type_utf16 == u"Bytes") { return RecordBatchStreamReader::fromBytes(constructor_arguments); - } else if (type_utf16 == u"Filename") { + } else if (type_utf16 == u"File") { return RecordBatchStreamReader::fromFile(constructor_arguments); } else { - // TODO: Create static error id string - return libmexclass::error::Error{"arrow:some:test:id", "Invalid construction type for RecordBatchStreamReader."}; + return libmexclass::error::Error{"arrow:io:ipc:InvalidConstructionType", "Invalid construction type for RecordBatchStreamReader."}; } }