Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases needed to be run before commits to master #34

Open
rbkn opened this issue Aug 18, 2023 · 2 comments
Open

Test cases needed to be run before commits to master #34

rbkn opened this issue Aug 18, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@rbkn
Copy link
Collaborator

rbkn commented Aug 18, 2023

Ideas:

  • check validity of xml output
  • check that the output is above a threshold size

Am happy to contribute here.
@mathewmeconry
Copy link
Owner

Hey @rbkn
Good idea. There are no test cases 😓 I did this a few years ago because I needed it.
Happy to have you added as a contributor if you like.

@rbkn
Copy link
Collaborator Author

rbkn commented Aug 21, 2023

Great will have a look later on. Will be a bit busy for a week or so!

@mathewmeconry mathewmeconry added the good first issue Good for newcomers label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathewmeconry @rbkn