Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show upgrade message and do not render child routes when database upgrade needs attention #4127

Open
pavish opened this issue Jan 14, 2025 · 0 comments
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue work: frontend Related to frontend code in the mathesar_ui directory

Comments

@pavish
Copy link
Member

pavish commented Jan 14, 2025

Description

  • This is a follow-up of Implement UI for upgrading databases #4123.
  • Upgrade Mathesar service.
    • Inorder to test locally, modify the last_confirmed_sql_version column in the mathesar_database django table.
  • Visit the home page. Upgrade message is shown.
  • Visit the database page (/db/<databsae_id>/) or any of the child routes (/db/<database_id>/schemas/<schema_oid>/).
  • These pages are rendered as usual, which may cause unexpected results/bugs if the sql has changed considerably.

Expected behaviour

  • When needs_upgrade_attention property of the database model is true, the database route should show an upgrade UI similar to the upgrade modal. The child routes should redirect to the database page.
@pavish pavish added type: bug work: frontend Related to frontend code in the mathesar_ui directory ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue labels Jan 14, 2025
@kgodey kgodey removed the type: bug label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

No branches or pull requests

2 participants