Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reset the password for a login role through UI #4092

Open
2 tasks
Anish9901 opened this issue Dec 18, 2024 · 4 comments
Open
2 tasks

Cannot reset the password for a login role through UI #4092

Anish9901 opened this issue Dec 18, 2024 · 4 comments
Labels
beta: approved Temporary label to mark issues that are approved needs: requirements The problem is clear and worth solving, but we're not yet sure of the best solution restricted: maintainers Only maintainers can resolve this issue

Comments

@Anish9901
Copy link
Member

Anish9901 commented Dec 18, 2024

Description

  • We don't perform any validation while configuring a new role on mathesar
  • So if we have created a login role 'bob' with password 'bobisgreat' it can be configured in mathesar with any random password e.g. 'bob_bob' because there is no validation
  • This can be a problem when an admin grants a bunch of privileges to 'bob' and assigns a mathesar user to connect using bob, only to find out that the mathesar user cannot access anything because the password is wrong.
  • The role cannot be dropped easily because other objects might depend on it
  • Also there is no way to reset the password for the role 'bob'.

Tasks

Preview Give feedback
  1. 0 of 3
    affects: ux beta: approved needs: ux design restricted: maintainers work: backend work: frontend
  2. affects: ux beta: needs discussion needs: ux design restricted: maintainers work: backend work: frontend
@Anish9901 Anish9901 added restricted: maintainers Only maintainers can resolve this issue needs: requirements The problem is clear and worth solving, but we're not yet sure of the best solution beta: needs discussion Temporary label to mark issues that need discussion labels Dec 18, 2024
@Anish9901 Anish9901 added this to the v0.2.0 (beta release) milestone Dec 18, 2024
@mathemancer
Copy link
Contributor

I prefer the first option.

@kgodey kgodey added beta: approved Temporary label to mark issues that are approved and removed beta: needs discussion Temporary label to mark issues that need discussion labels Dec 22, 2024
@pavish
Copy link
Member

pavish commented Dec 23, 2024

Also there is no way to reset the password for the role 'bob'
only to find out that the mathesar user cannot access anything because the password is wrong

Stored passwords for configured roles can be modified via the UI in the "Configurd Roles" page. I'm not sure why the user would want to reset the role password on the DB in this scenario.

That said, I do agree that we should automatically configure the role in Mathesar when a new role is created via the UI. We would probably need to mention somewhere on the UI that the role password will be stored in Mathesar automatically and allow the user to not store it if they don't want to.

@seancolsen
Copy link
Contributor

seancolsen commented Jan 7, 2025

@kgodey I think we should check in about this at a meeting ASAP to figure out whether we want to address this for beta, and if so: how. This is another one of those small issues that would cut through a large slice of our stack and potentially require design work. So if we're going to take it up, we need to get some clarity on it immediately.

@kgodey
Copy link
Contributor

kgodey commented Jan 15, 2025

Just following up to say that we did discuss this at a meeting and moved this out of beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta: approved Temporary label to mark issues that are approved needs: requirements The problem is clear and worth solving, but we're not yet sure of the best solution restricted: maintainers Only maintainers can resolve this issue
Projects
None yet
Development

No branches or pull requests

6 participants