-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor Android Flavor and build.prop probe #53
Comments
While I am at it...it looks like I could get turn pastime's list of files.txt definitions into a function---I think it is there twice. Also, at many, many points we test various depths for files. I am sure that could be functioned. Probably save use 75 lines. These mofo's: Just have the argument be the filename: depth_test(smali.txt)...etc., |
romhelp branch currently under way...this is proving to be a massive pain in the butt. Close but not there yet... |
Just a revisit...this needs to happen SO bad. I keep wanting to work on the readability of the code, but the help and error-checks have taken over. But those are getting in real good shape...the refactor is really important. Let's break it into chunks: To be edited. But I want to do this before I move beyond the shell script. |
Using the 'case' separators ";&" and ";;&" could probably be used to filter ROM types more efficiently. |
The actual build date query is pretty lean and mean. I really like that section. But the build.prop query section is a horrible mess. It has just grown out of the various Android flavors and there is a bunch of repeated code.
That needs to be slimmed down. I can still call whatever functions are specific to flavors without that whole mess.
The text was updated successfully, but these errors were encountered: