Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratcheting with glob threshold coverage #106

Open
tmjam opened this issue Nov 18, 2020 · 2 comments
Open

ratcheting with glob threshold coverage #106

tmjam opened this issue Nov 18, 2020 · 2 comments

Comments

@tmjam
Copy link

tmjam commented Nov 18, 2020

Is it possible to use jest-ratchet when you have glob coverageThresholds setup along with global thresholds, currently I am not seeing thresholds update when using glob patterns
example:

"./src/util": {
    "functions": 70,
    "lines": 70,
    "statements": 70
}
@markis
Copy link
Owner

markis commented Nov 19, 2020

That's not something that I had considered.

How should it work if there is a glob and a specific file that apply to the increased coverage? How should it work with overlapping globs?

@tmjam
Copy link
Author

tmjam commented Nov 19, 2020

Hi @markis
The expected behavior would be the same as Jest would handle the threshold checks for globs and update them accordingly.
If I have globs currently none of the thresholds get updated and is probably failing silently somewhere. I do see it iterating over the keys here but haven't dug into it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants